Modernization #50
Merged
Modernization #50
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… body & pass original errors in CoreSdkError
pokornyd
reviewed
Jun 16, 2025
lib/utils/error.utils.ts
Outdated
| return `Response failed with status '${adapterResponse.status}' and status text '${adapterResponse.statusText}'.${kontentErrorResponse.message}${validationErrorMessage ? ` ${validationErrorMessage}` : ""}`; | ||
| } | ||
|
|
||
| return undefined; |
There was a problem hiding this comment.
I would probably fallback to some string like "unknown error" or returned the stringified response or something. that way you could simplify the return value of getErrorMessage on line 22.
There was a problem hiding this comment.
The unknown error should be reserved for cases which are not accounted for. In this case, I want to give the user a "friendly" error message with status codes & flattened validation error message. This case only happens when the requests itself succeeds, but fails due to Kontent.ai validation.
I did simplify the code here a bit though :)
pokornyd
approved these changes
Jun 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Which issue does this fix? Fixes #
issue numberIf no issue exists, what is the fix or new feature? Were there any reasons to fix/implement things that are not obvious?
Checklist
How to test
If manual testing is required, what are the steps?